Skip to content

fix: Automatically install nightly toolchain when missing #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 16, 2025
Merged

fix: Automatically install nightly toolchain when missing #2886

merged 4 commits into from
Aug 16, 2025

Conversation

byfnoel
Copy link
Contributor

@byfnoel byfnoel commented Aug 10, 2025

This change ensures that the required Rust toolchain is installed automatically if it is missing.

Fixes: #2051

byfnoel added 2 commits August 10, 2025 09:52
@byfnoel
fix: Automatically install nightly toolchain when missing
c394d9b 
This will install the nightly toolchain automatically when
we detect it missing.

Fixes: 2051
@byfnoel
Merge branch 'rust-lang:master' into auto-install-toolchain
541a91e
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Aug 10, 2025
@byfnoel byfnoel marked this pull request as ready for review August 10, 2025 14:52
@byfnoel byfnoel requested a review from a team as a code owner August 10, 2025 14:52
@byfnoel
Copy link
Contributor Author

byfnoel commented Aug 11, 2025

I'd love to get this PR reviewed @GuillaumeGomez @syphar.

@GuillaumeGomez
Copy link
Member

Still gonna wait for @syphar to take a look.

syphar
syphar requested changes Aug 12, 2025
View reviewed changes
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the fix! I remember this annoys me every time I have to set up a fresh environment.

I can do some manual testing later this week,

but until then it would be cool if you could add tests for add-essential-files with or without toolchain?

@byfnoel byfnoel requested a review from syphar August 14, 2025 18:31
@byfnoel
Copy link
Contributor Author

byfnoel commented Aug 16, 2025

but until then it would be cool if you could add tests for add-essential-files with or without toolchain?

Thank you, @syphar. I added tests that try the new behavior.

@syphar
Copy link
Member

syphar commented Aug 16, 2025

thanks!

@syphar syphar merged commit ebd50d2 into rust-lang:master Aug 16, 2025
10 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Aug 16, 2025
@syphar
Copy link
Member

syphar commented Aug 16, 2025

@byfnoel the tests fail on master, can you check why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syphar syphar syphar approved these changes

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees
No one assigned
Labels
S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running cratesfyi add-essential-files fails if nightly toolchain not installed
3 participants
@byfnoel @GuillaumeGomez @syphar